From a22a055fe3fb4ce4e4d129fa4b692c66f0f4313b Mon Sep 17 00:00:00 2001
From: Yorick Barbanneau <ephase@xieme-art.org>
Date: Wed, 12 Feb 2020 15:57:16 +0100
Subject: [PATCH] Use `while read <` in process_conf_file()

---
 init.sh | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/init.sh b/init.sh
index bcdcfab..6640f91 100755
--- a/init.sh
+++ b/init.sh
@@ -131,7 +131,7 @@ http_response=$(wget --spider --server-response "$url" 2>&1 | grep HTTP/ | tail
 if [ "$http_response" -eq 200 ]
 then
     wget -c --progress=dot "$url" 2>&1 | grep --line-buffered "[0-9]\{1,3\}%" -o | awk '{printf ("\b\b\b\b%4s", $1)}'
-    if [ "$?" -eq 0 ]
+    if [ $? -eq 0 ]
     then
         printf " \b\b\b\b\b done\n "
     else
@@ -145,12 +145,13 @@ fi
 }
 
 process_conf_file (){
-for p in `cat $1 | grep '^[^#].*'`
-do
-   var=`echo "$p" | awk -F"=" '{print $1}'`
-   param=`echo "$p" | awk -F"=" '{print $2}'`
-   eval $var=$param
-done
+    while read -r p
+    do
+        var=$(echo "$p" | awk -F"=" '{print $1}')
+        param=$(echo "$p" | awk -F"=" '{print $2}')
+        eval "$var"="$param"
+    done < <( cat "$1" | grep '^[^#].*')
+
 }
 
 create_dir(){