From 79bda5ab72b3d7177fb70aa4e313572dec9e5bcd Mon Sep 17 00:00:00 2001
From: Yorick Barbanneau <ephase@xieme-art.org>
Date: Sun, 14 Jan 2024 14:15:16 +0100
Subject: [PATCH] Make spellcheck happy

---
 .../video/kdenlive/files/create_conf          | 28 +++++++++----------
 1 file changed, 13 insertions(+), 15 deletions(-)

diff --git a/modules/home-manager/video/kdenlive/files/create_conf b/modules/home-manager/video/kdenlive/files/create_conf
index ca17715..3612418 100755
--- a/modules/home-manager/video/kdenlive/files/create_conf
+++ b/modules/home-manager/video/kdenlive/files/create_conf
@@ -8,7 +8,7 @@ die() {
     error "$*"
     exit 1
 }
-
+# shellcheck disable=SC2317
 process_args() {
     while :; do
         case $1 in
@@ -35,7 +35,7 @@ get_file_hash() {
         then
             if (( file_size > 0 ))
                 then
-                if (( $file_size > 2000000 ))
+                if (( file_size > 2000000 ))
                 then
                     #calculate
                     local tmp_file
@@ -56,7 +56,6 @@ get_file_hash() {
 
 get_file_size() {
     local file
-    local a
     file=$1
     if [ -f "$file" ]
     then
@@ -82,12 +81,11 @@ insert_media() {
     sed -i -e "s#\[\[${tag}\]\]#${filename}#g" \
         -e "s#\[\[${tag}_filesize\]\]#${filesize}#g" \
         -e "s#\[\[${tag}_filehash\]\]#${filehash}#g" \
-        ${folder}"/montage.kdenlive" || {
+        "${folder}/montage.kdenlive" || {
             error "sed command error on insert media!"
         }
 }
 
-test=""
 base_dir="${HOME}/medias/videos/sambab"
 
 conf="$*"
@@ -104,19 +102,19 @@ friday=$(date --date='last Friday' +"%Y.%m.%d")
 folder="${base_dir}/${friday}-${conf// /_}"
 
 #create it
-mkdir "${folder}"/{rushes,audio,titles} -p || die "folder creation failed"
+mkdir "${folder}/"{rushes,audio,titles} -p || die "folder creation failed"
 
 
 cp "${base_dir}/logo_amis.svg" "${folder}/titles" || die "SVG copy failed!"
-cp "${base_dir}/template.kdenlive" "${folder}/montage.kdenlive" || dir "Template copy failed!" }
+cp "${base_dir}/template.kdenlive" "${folder}/montage.kdenlive" || die "Template copy failed!"
 
 inkscape_date=$(LC_ALL=fr_FR.UTF-8 date --date='last Friday' +"%A %d %B %Y")
 
 printf "Put Name on title\n"
-sed -i "s/\[\[conf\]\]/${conf//_/ }/g" ${folder}/titles/logo_amis.svg || die "Change text on credits screen failed!"
+sed -i "s/\[\[conf\]\]/${conf//_/ }/g" "${folder}/titles/logo_amis.svg" || die "Change text on credits screen failed!"
 
 printf "Put date on title\n"
-sed -i "s/\[\[date\]\]/${inkscape_date}/g" ${folder}/titles/logo_amis.svg || die "Change date failed!"
+sed -i "s/\[\[date\]\]/${inkscape_date}/g" "${folder}/titles/logo_amis.svg" || die "Change date failed!"
 
 printf "Export SVG title \n"
 inkscape --export-type="png" "${folder}/titles/logo_amis.svg" || die "Export failed" 
@@ -125,11 +123,11 @@ printf "Importing PNG File in %s/montage.kdenlive \n" "$folder"
 insert_media "$folder/titles/logo_amis.png" "logo"
 
 echo "Mount USBkey with Label $key_label"
-usb_key="/dev/$(lsblk -o KNAME,LABEL | grep ${key_label} | awk '{print $1}')"
+usb_key="/dev/$(lsblk -o KNAME,LABEL | grep "${key_label}" | awk '{print $1}')"
 [[ ! $usb_key = "/dev/" ]] || die "Can't getting device name, is USB key plugged? $usb_key"
 
 
-disk="$(udisksctl mount -b ${usb_key} | awk '{print $4}')"
+disk="$(udisksctl mount -b "${usb_key}" | awk '{print $4}')"
 sleep 1
 [[ -n $disk ]] || die " -> Error mounting device $usb_key"
 
@@ -137,8 +135,8 @@ sleep 1
 printf "Change root folder in montage.kdenlive to %s\n" "$folder"
 sed -i -e "s#\[\[root_folder\]\]#${folder}#g" "${folder}/montage.kdenlive"
 
-printf "Copying Audio File\n" "$folder"
-if mv "${disk}/RECORD/EXREC/*.MP3" "${folder}/audio/audio.mp3";
+printf "Copying Audio File: %s\n" "$folder"
+if mv "${disk}/RECORD/EXREC/"*.MP3 "${folder}/audio/audio.mp3";
 then
     # import audio file
     printf "Importing Audio File in %s/montage.kdenlive \n" "$folder"
@@ -148,12 +146,12 @@ else
 fi
 
 printf "Copying Video File\n"
-if mv "${disk}/$(date --date='last Friday' +'%Y-%m-%d')\ *.mkv" "${folder}/rushes/obs.mkv";
+if mv "${disk}/$(date --date='last Friday' +'%Y-%m-%d')"\ *.mkv "${folder}/rushes/obs.mkv";
 then
         insert_media "${folder}/rushes/obs.mkv" video
 else
     error "Moving video file failed!"
 fi
 
-udisksctl unmount -b ${usb_key}
+udisksctl unmount -b "${usb_key}"
 exit 0